NETOBSERV-1816 allow n/a filter #590
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #590 +/- ##
==========================================
- Coverage 56.29% 56.27% -0.02%
==========================================
Files 190 190
Lines 9289 9304 +15
Branches 1197 1201 +4
==========================================
+ Hits 5229 5236 +7
- Misses 3691 3698 +7
- Partials 369 370 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jotak
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=1570e7b make set-plugin-image |
|
|
||
| // Convenience string to filter by undefined field values | ||
| export const undefinedValue = '""'; | ||
| // Unique double are allowed while typing but invalid |
There was a problem hiding this comment.
@jpinsonneau could we use just an empty string as undefined value? I feel it would make more sense, at least for non-string values, than using "". wdyt?
There was a problem hiding this comment.
(If we stick to using "" IMO we should mention it in the help tips because it's sounds less intuitive)
github-actions
bot
removed
the
ok-to-test
jotak
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=f127614 make set-plugin-image |
|
👌 |
|
@jpinsonneau I now see all filters now accept |
|
|
New changes are detected. LGTM label has been removed. |
github-actions
bot
removed
the
ok-to-test
jpinsonneau
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=c64e024 make set-plugin-image |
|
That helped. Works as expected! |
|
Awesome, thanks @Amoghrd ! |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Description
Allow filtering on
n/aby searching on strict value""in the text input.Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.